test: read receipts #30637
Merged
test: read receipts #30637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/RocketChat/Rocket.Chat into fix/receipts-not-created-first-read
🦋 Changeset detectedLatest commit: 91f8410 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30637 +/- ##
===========================================
- Coverage 51.34% 51.14% -0.20%
===========================================
Files 815 815
Lines 15121 15271 +150
Branches 2754 2834 +80
===========================================
+ Hits 7764 7811 +47
- Misses 6948 7020 +72
- Partials 409 440 +31
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
pierre-lehnen-rc
requested changes
Oct 25, 2023
There was a problem hiding this comment.
You'll need multiple describe sections for all situations you're testing, each one with their own messages in the correct state.
1 - simple message and thread that nobody has read yet
2 - simple message and thread where the room message was read by another user but the thread message was not
3 - another test where everything was read by both users
4 - another test that checks the result of getReadReceipts after the call to readThreads
dionisio-bot
bot
added
stat: ready to merge
pierre-lehnen-rc
requested changes
Oct 30, 2023
dionisio-bot
bot
removed
the
stat: ready to merge
pierre-lehnen-rc
approved these changes
Oct 30, 2023
heitortanoue
added
the
stat: ready to merge
hugocostadev
pushed a commit
that referenced
this pull request
Oct 31, 2023
Co-authored-by: Matheus Barbosa Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Create a new file dedicated to the read-receipts feature tests and improve its coverage (including some edge-cases introduced in the last major release).
Issue(s)
Steps to test or reproduce
Further comments
TC-502